test: remove flaky basic_expiry integration test #695
Merged
+0
−42
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace fixed sleep durations with retry loops that actively poll for expected routing state. This eliminates timing-related flakiness in CI environments where task scheduling is less predictable. Changes: - Add wait_for_routing_to_domains helper that polls until expected domains are available - Update test to use retry loops with timeouts instead of fixed sleeps - Remove timing assumptions that failed in CI due to scheduler variance Co-Authored-By: Claude Sonnet 4.5 <[email protected]>
lwshang
changed the title
Increase sample sizes and timeouts to account for CI environment variability: - Use 10 samples for single domain, 30 for multiple (matching other tests) - Calculate timeouts based on snapshot_update_duration (fetch + 2*check intervals) - Increase poll interval to 100ms to reduce overhead These changes align with the timing patterns used in other routing tests and provide sufficient margin for CI scheduler variance. Co-Authored-By: Claude Sonnet 4.5 <[email protected]>
Revert "test: fix flaky test_route_with_one_healthy_and_one_unhealthy_seed" These commits attempted to fix the flaky test with retry logic, but the test continues to fail in CI. Reverting to consider alternative approaches.
lwshang
changed the title
adamspofford-dfinity
approved these changes
Jan 30, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Remove
basic_expirytest - Testing zero-expiry timeouts withcall_and_wait()is inherently timing-sensitive and unreliable in CI environmentsbasic_expiryfailure: https://github.com/dfinity/agent-rs/actions/runs/21454157198/job/61790461795#step:8:758